Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrects a typo and be more explicit about RStudio #557

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

DanChaltiel
Copy link
Contributor

cf #554

@gaborcsardi
Copy link
Member

@romainfrancois Do you remember that .run links need the package to be loaded or attached? Has this behaviour changed since rstudio/rstudio#11318 was merged?

@gaborcsardi
Copy link
Member

@romainfrancois Seems like it has to be attached. Is this intentional? According to rstudio/rstudio#11318 loading should be enough, no?

@romainfrancois
Copy link
Contributor

I think it just has to be installed. at the end of the day, it goes though this function:

> .rs.isPackageHyperlinkSafe
function (packageName) 
{
    allowed <- setdiff(c(.packages(), "testthat", "rlang", "devtools", 
        "usethis"), c("base", "stats", "utils"))
    .rs.scalar(packageName %in% allowed)
}

if this returns TRUE, the code is executed, otherwise just copied into the console.

@gaborcsardi
Copy link
Member

That's not what I see, though. I need to attach the package, loading does not work.

@romainfrancois
Copy link
Contributor

I'll investigate some more. It might have changed in cherry blossom (dev).

@gaborcsardi
Copy link
Member

Thanks!

@gaborcsardi gaborcsardi merged commit 48379f0 into r-lib:main Sep 13, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants