Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-coverage.yaml should fail on error #947

Open
Moohan opened this issue Nov 19, 2024 · 0 comments
Open

test-coverage.yaml should fail on error #947

Moohan opened this issue Nov 19, 2024 · 0 comments
Labels
bug an unexpected problem or unintended behavior

Comments

@Moohan
Copy link

Moohan commented Nov 19, 2024

debendabot recommended updating the codecov action from 4 to 5 in our test-coverage.yaml. In the release notes, there are some breaking changes that will affect the current r-lib example: file: becomes files: and plugin: becomes plugins: I was surprised to see the workflow had passed on the PR though... Looking at the job details - https://github.com/Public-Health-Scotland/phsopendata/actions/runs/11883091545/job/33109379336 we can see that the action reported a warning and an error but the overall workflow still reported passing for some reason.

I'm not sure if this is something you can update or if it's part of the codecov action itself.

@Moohan Moohan added the bug an unexpected problem or unintended behavior label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

1 participant