Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests #40

Open
2 of 3 tasks
GegznaV opened this issue Jun 19, 2022 · 1 comment
Open
2 of 3 tasks

Fix unit tests #40

GegznaV opened this issue Jun 19, 2022 · 1 comment

Comments

@GegznaV
Copy link
Member

GegznaV commented Jun 19, 2022

I installed unmixR locally. I ran the unit tests in two ways and they failed on my machine.

  1. unmixR.unittest()

image

  1. devtools::test()
Results (truncated):
ℹ Testing unmixR
✔ | F W S  OK | Context
...
────────────────────────────────────────────────────
...
✖ | 2   2   7 | vca [0.2s] 
────────────────────────────────────────────────────

Error (vca.default.R:76:7): correct results for all available methods: triangle data
Error in `vca.default(.testdata$x, p = 3, method = i)`: object '.Random.seed' not found
Backtrace:
 1. testthat::expect_equal(...)
      at unmixR/R/vca.default.R:76:6
 5. unmixR::vca.default(.testdata$x, p = 3, method = i)
      at unmixR/R/vca.R:63:2
...
Error (vca.default.R:104:5): vca output is sorted
Error in `vca.default(.testdata$x, p = 3)`: object '.Random.seed' not found
Backtrace:
 1. unmixR::vca(.testdata$x, p = 3)
      at unmixR/R/vca.default.R:104:4
 2. unmixR::vca.default(.testdata$x, p = 3)
      at unmixR/R/vca.R:63:2
────────────────────────────────────────────────────
✖ | 1       5 | simplex_volume                      
────────────────────────────────────────────────────
Failure (simplex.R:106:5): correct volumes for triangle data
simplex_volume(triangle_2d, factorial = FALSE) not equal to `area_2d`.
1/1 mismatches
[1] 1 - 0.5 == 0.5

...

══ Results ═════════════════════════════════════════
Duration: 0.8 s

── Skipped tests  ──────────────────────────────────
• known issue: #36 (1)
• LDU skipped: known issue #38 (2)
• temporarily disabled (1)

[ FAIL 3 | WARN 0 | SKIP 4 | PASS 49 ]

Can these be fixed, @rguliev, @bryanhanson?


Tasks:

@GegznaV
Copy link
Member Author

GegznaV commented Jun 19, 2022

Is an update related to a newer version of either R, or testthat, or other packages are needed?

@GegznaV GegznaV changed the title Unit tests fail locally Fix unit tests Jun 19, 2022
@GegznaV GegznaV mentioned this issue Jun 19, 2022
@rguliev rguliev linked a pull request Jun 19, 2022 that will close this issue
@rguliev rguliev removed a link to a pull request Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant