From c2a7c60a54c4679f1ba0cde845176caa575a65f2 Mon Sep 17 00:00:00 2001 From: Richard Barnes Date: Wed, 24 Jan 2024 12:56:40 -0800 Subject: [PATCH] Remove unused exception parameter from fbpcs/data_processing/id_combiner/IdSwapMultiKey.cpp Summary: `-Wunused-exception-parameter` has identified an unused exception parameter. This diff removes it. This: ``` try { ... } catch (exception& e) { // no use of e } ``` should instead be written as ``` } catch (exception&) { ``` If the code compiles, this is safe to land. Reviewed By: dmm-fb Differential Revision: D52957687 --- fbpcs/data_processing/id_combiner/IdSwapMultiKey.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fbpcs/data_processing/id_combiner/IdSwapMultiKey.cpp b/fbpcs/data_processing/id_combiner/IdSwapMultiKey.cpp index f135bf8c4..7aa874f17 100644 --- a/fbpcs/data_processing/id_combiner/IdSwapMultiKey.cpp +++ b/fbpcs/data_processing/id_combiner/IdSwapMultiKey.cpp @@ -57,7 +57,7 @@ void aggregateLiftNonIdColumns( try { int32_t val = std::stoi(dRow[col]); columnValues[col].push_back(val); - } catch (std::exception& err) { + } catch (std::exception&) { XLOG(FATAL) << "Error: Exception caught during casting string to int.\n" << "\tFor PL, non-id columns has to be int to aggregate in case of duplicates.";