From b1af1fc244bca325b7e03656cacf151635edd7ce Mon Sep 17 00:00:00 2001 From: Richard Barnes Date: Wed, 24 Jan 2024 12:41:20 -0800 Subject: [PATCH] Remove unused exception parameter from fbpcs/data_processing/id_combiner/DataValidation.cpp Summary: `-Wunused-exception-parameter` has identified an unused exception parameter. This diff removes it. This: ``` try { ... } catch (exception& e) { // no use of e } ``` should instead be written as ``` } catch (exception&) { ``` If the code compiles, this is safe to land. Reviewed By: yanglu-fb Differential Revision: D52957709 --- fbpcs/data_processing/id_combiner/DataValidation.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fbpcs/data_processing/id_combiner/DataValidation.cpp b/fbpcs/data_processing/id_combiner/DataValidation.cpp index 497518d97..06c1c63ab 100644 --- a/fbpcs/data_processing/id_combiner/DataValidation.cpp +++ b/fbpcs/data_processing/id_combiner/DataValidation.cpp @@ -60,7 +60,7 @@ void validateCsvData(std::istream& dataFile) { for (auto& v : rowVec) { try { folly::to(v); - } catch (std::exception& e) { + } catch (std::exception&) { XLOG(FATAL) << v << " failed to parse to int"; } }