Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #108

Closed
1 of 4 tasks
mikegerber opened this issue Apr 25, 2024 · 6 comments
Closed
1 of 4 tasks

Windows support #108

mikegerber opened this issue Apr 25, 2024 · 6 comments
Assignees

Comments

@mikegerber
Copy link
Member

mikegerber commented Apr 25, 2024

dinglehopper does not seem to run on Windows, because Microsoft Store has Python 3.12 and OCR-D core is not ready yet (OCR-D/core#1212).

We already test Python 3.12, why did we not see this error in our tests?

  • Fix
  • Is there a better way to set PATH?
  • Test on Windows (GitHub Actions has windows-latest)
  • Assess if building an MSI using cx_Freeze is doable + how much of an effort would it be?
@mikegerber
Copy link
Member Author

(No idea if it would run on Windows if this is fixed, though)

@mikegerber mikegerber self-assigned this Apr 25, 2024
@mikegerber
Copy link
Member Author

https://github.com/qurator-spk/dinglehopper/wiki/Windows-support

Python 3.11 works, at least with a simple test.

@mikegerber
Copy link
Member Author

mikegerber commented Apr 26, 2024

The Windows user's IT department wasn't happy with installing Python + an doing a pip install and wants an MSI/setup.exe...

@mikegerber mikegerber changed the title Test native Windows support, review Python 3.12. Test native Windows support Apr 26, 2024
@mikegerber
Copy link
Member Author

Python 3.12 now works, too. Updating this issue with a TODO list.

@mikegerber mikegerber changed the title Test native Windows support Windows support May 7, 2024
@mikegerber
Copy link
Member Author

We already test Python 3.12, why did we not see this error in our tests?

We don't test the CLIs directly → #112

@mikegerber
Copy link
Member Author

I've added a recommendation to use Linux instead to the Wiki article.

To be honest, there are now two options to use this on Windows:

  1. Use WSL (preferred and recommended - I use WSL for development)
  2. Use the method from the Wiki article

If the user's IT department isn't willing to provide either option (both from Microsoft!), then I can't help, within reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant