Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cosmological expansion terms #699

Open
BenWibking opened this issue Aug 2, 2024 · 2 comments
Open

add cosmological expansion terms #699

BenWibking opened this issue Aug 2, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@BenWibking
Copy link
Collaborator

BenWibking commented Aug 2, 2024

Describe the proposal
Add cosmological expansion (i.e., Hubble flow) terms to the equations of motion.

The easiest way to do this may be to adopt supercomoving coordinates (Martel & Shapiro 1997), although it's unclear whether this generalizes to beyond a gamma-law EOS.

We can also adopt the trick used by FLASH to integrate the Friedmann equation exactly (https://flash.rochester.edu/site/flashcode/user_support/flash4_ug_4p71/node137.html), although the documentation does not reflect what the code actually does for this.

Describe alternatives you've considered
Don't do cosmology.

Additional context
This is needed for cosmological PopIII stars.

cc @psharda

@BenWibking BenWibking added the enhancement New feature or request label Aug 2, 2024
@BenWibking
Copy link
Collaborator Author

@BenWibking
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant