fix: update (hotels&airports) #78
Conversation
There was a problem hiding this comment.
In that case I assume it makes more sense to set an ID tag name here:
https://github.com/frzifus/lets-party/blob/4ffa29606aef281942efea4a048d3d51b4bbe659/intern/model/guest.go#L40
I remember that the ID tag was removed because the unmarshal function did panic.
Maybe we'll apply this change as a "hotfix" and add some tests for the form.Unmarshal function later?
|
Just an update: As requested i added the comment. I'm trying to fix this the next few days. |
intern/parser/form/form.go
Outdated
| case reflect.TypeOf(uuid.UUID{}).Kind(): | ||
| if fieldValRaw == "" { | ||
| continue | ||
| } | ||
| parsedUUID := uuid.MustParse(fieldValRaw) | ||
|
|
||
| fieldVal.Set(reflect.ValueOf(parsedUUID)) |
There was a problem hiding this comment.
Good stuff, but that would mean we have to implement any new type definition?
Since uuid.UUID is a [16]byte, can we maybe change the case to check for reflect.Array instead?
And in case that does not work, we could maybe provide a way to extend the Unmarshal capabilities by providing a custom HtmlFormUnmarshaler implementation.
case reflect.TypeOf((*HtmlFormUnmarshaler)(nil)).Elem().Kind():
if fieldValRaw == "" {
continue
}
fieldValue := reflect.New(field.Type).Interface().(HtmlFormUnmarshaler)
if err := fieldValue.UnmarshalFormValue(fieldValRaw); err != nil {
return err
}
fieldVal.Set(reflect.ValueOf(fieldValue).Elem())In that case uuid.UUID has to implement this method:
type HtmlFormUnmarshaler interface {
UnmarshalFormValue(value string) error
}For this we could wrap the wrap the type:
type UUID struct {
uuid.UUID
}
func (u *UUID) UnmarshalFormValue(value string) error {
panic("not implemented")
}There was a problem hiding this comment.
reflect.Array seems to work fine here
Seems like while iterating through airports & hotels they got the
model.Locationassigned.But the form-data is only unmarshalled into the model.
Therefore it doesn't get assigned with the correct uuid, but instead gets the uuid of the empty
model.Location.Just additionally assigning should solve this problem, otherwise you could also parse the UUID directly into the
model.Location(line 857).