fix(udp): do not enable URO on Windows on ARM #2071
Conversation
mxinden
force-pushed
the
no-uro-on-arm
branch
4 times, most recently
from
70ffc68
to
c958ab5
Compare
|
Given your involvement on #2041, @thomaseizinger @stormshield-damiend do you have thoughts? @valenting since you had the idea of using |
i am ok with this approach, this prevent issue for people that uses Windows ARM + WSL and gives us some time to understand the root cause. |
mxinden
force-pushed
the
no-uro-on-arm
branch
from
c958ab5
to
653e382
Compare
On Windows on ARM with Windows Subsystem for Linux (WSL) `WSA_RECVMSG` does not return the segment size of coalesced UDP datagrams. See quinn-rs#2041 for details. While lacking a fix for the root cause, don't enable URO, i.e. don't coalesce UDP datagrams on Windows on ARM.
mxinden
force-pushed
the
no-uro-on-arm
branch
from
653e382
to
4e23e95
Compare
There was a problem hiding this comment.
I'll have to double check but I think the user that ran into this with Firezone was on x64.
Happy for this to merge regardless.
We could also consider adding a config option, defaulting to disabled and with a warning that it may not work on all systems.
I think I'd rather disable GRO completely for Firezone on Windows until we get to the bottom of this. Or add some kind of compatibility switch.
On Windows on ARM with Windows Subsystem for Linux (WSL)
WSA_RECVMSGdoes not return the segment size of coalesced UDP datagrams. See #2041 for details.While lacking a fix for the root cause, don't enable URO, i.e. don't coalesce UDP datagrams, on Windows on ARM.