Miscellaneous cleanup #1581
Merged
Miscellaneous cleanup #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Jun 3, 2023
Ah, right, forgot the new policy. |
djc
approved these changes
Jun 3, 2023
This was previously used by the `quinn` layer to stop accepting connections when the `Incoming` stream was dropped. That stream has since been replaced by an async function. Users who still want this can use set_server_config directly.
Simplifies signatures and prepares for non-connection-related datagram events.
Guards against future bugs where multiple (e.g. concurrent) calls to `new_cid` might otherwise lead to an undetected collision.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straightforward improvements extracted from #1578.