Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve quic:stream_state_updated #374

Open
rmarx opened this issue Jan 19, 2024 · 3 comments
Open

Improve quic:stream_state_updated #374

rmarx opened this issue Jan 19, 2024 · 3 comments
Assignees

Comments

@rmarx
Copy link
Contributor

rmarx commented Jan 19, 2024

As reported by @hlandau on the mailing list:

quic:stream_state_updated:

I think this needs to be clarified a little that an event logged here with both
a stream_id field and a stream_side field is expressing a state for that
component of the stream and from the perspective of the specified vantage point
(also, what about the network vantage point?); whereas an event logged here
with a stream_id field but no stream_side field is expressing a state for
both stream components as a whole.

If my interpretation here is correct, I think it would also help to note that
the valid values of StreamState depend on the value and presence of
stream_side.

@rmarx
Copy link
Contributor Author

rmarx commented Jan 19, 2024

Specifically for the "network vantage point" aspect of the question: the intent was that a network observer would use "sending" vs "receiving" depending on which party opened the stream, but that indeed falls down when using bidi streams...

I think there is some overlap here with the stream_state values and their implied-ness for either one or both sides, but I think @LPardue has a better grasp on this than me.

@rmarx
Copy link
Contributor Author

rmarx commented Jun 24, 2024

@LPardue could use some input on this here :)

@LPardue
Copy link
Member

LPardue commented Nov 4, 2024

I have never used this event myself and have little experience to impart. There's no text to describe how stream_side is supposed to be used, which isn't great.

Not sure what to do here tbh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants