Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using a fork instead of an npm package or patch #217

Open
HarelM opened this issue Dec 17, 2018 · 3 comments
Open

Allow using a fork instead of an npm package or patch #217

HarelM opened this issue Dec 17, 2018 · 3 comments

Comments

@HarelM
Copy link
Contributor

HarelM commented Dec 17, 2018

Current implementation of this package does not allow contributor to test their fork before submitting a pull request.
Since in next version the dist folder is no longer checked-in (which is good) one cannot fork and use npm install git+....
In the npm documentation there's a prepare script that might facilitate for this.
However, since the repository has two goal - the library and the example it creates a problem for this.
One solution is to split this to two repositories - one for the example and the other for the library, the other option is to force the prepare script to copy/remove files in order to be able to create the library so it will be possible to reference it.
I don't have a magical solution, I just want to be able to use my fork without creating an npm package.
If you are familiar with other solutions I would love to hear.

@HarelM HarelM changed the title Allow using a fork instead of an npm package Allow using a fork instead of an npm package or patch Dec 17, 2018
@Neonox31
Copy link
Collaborator

First, thanks for pointing this use case, I never used it and just discovered the prepare script.
Unfortunately this project could not be splitted into two distinct repositories for the moment because it is builded with Angular CLI whiches force to generate a main project (demo here) before creating a library.

I tried to install from git using a subfolder with NPM but sadly it is not possible at now 😢 here is the issue : npm/npm#2974

@HarelM
Copy link
Contributor Author

HarelM commented Jan 11, 2019

Thanks for the info. I'm currently using a patch of a local version I created.
I would say that if the rate pull requests adoption was decent this use case would not have been something I needed (although someone else might), but I have a pull request that is waiting for more than a month without any comment so I gave up on trying to contribute and I'm now looking for a way to use the local changes I did...
I'm planning on using this library in production and would love to help out (much like the two PRs I sent), but unfortunately my changes are not being used...

@Neonox31
Copy link
Collaborator

Sorry for that, we have a lot of work to do simultaneously of this project.
I just mentionned maintainers for your P.R.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants