Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable image size and padding #935

Open
MosGeo opened this issue Oct 7, 2024 · 1 comment
Open

Variable image size and padding #935

MosGeo opened this issue Oct 7, 2024 · 1 comment

Comments

@MosGeo
Copy link

MosGeo commented Oct 7, 2024

Hi All,

From a technical perpsective, is there a specific reason why smp is not implementing unet with padding "same" to ensure applicability to different image sizes? as I understand it, this will not have an effect on already "correctly" sized images and it will enable variable image size. Is that correct?

@qubvel
Copy link
Collaborator

qubvel commented Oct 7, 2024

Hi, thanks for the issue, you are right 👍

One more solution might be to change the interpolation from scale factor to target size. Historically, there was an issue converting model to ONNX with size specified instead of scale factor, but I suppose it's no longer an issue.

In case you would like to contribute, I would appreciate a help on this feature!
This should be split into two separate PRs to avoid regression

  • add test for output equivalence (I can add it shortly)
  • change interpolation/add padding, both could be added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants