Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing functionality in Scheduler class #130

Open
rbarham opened this issue Dec 11, 2015 · 1 comment
Open

Missing functionality in Scheduler class #130

rbarham opened this issue Dec 11, 2015 · 1 comment

Comments

@rbarham
Copy link

rbarham commented Dec 11, 2015

I've noticed there are some missing features in some of the classes. For example, the qds_sdk.scheduler.Scheduler class doesn't have an edit/update or create method. I was able to pretty easily add this functionality to a class that extended "qds_sdk.scheduler.Scheduler".

class MyScheduler(Scheduler):
    def create(self):
        conn = Qubole.agent()
        return conn.post(Scheduler.rest_entity_path, self.attributes)

    def edit(self, args):
        conn = Qubole.agent()
        return conn.put(self.element_path(self.id), args)

It would be useful if this functionality exists in the SDK by default.

@rohitagarwal003
Copy link
Contributor

Hey @rbarham,

Please feel free to send a PR. Otherwise we also get someone to look into it. cc - @vrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants