Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markers #11

Open
mrharpo opened this issue Jan 22, 2020 · 0 comments
Open

Add markers #11

mrharpo opened this issue Jan 22, 2020 · 0 comments
Labels
enhancement ➕ New feature or request

Comments

@mrharpo
Copy link
Collaborator

mrharpo commented Jan 22, 2020

Create a Marker component.

Each marker will have a time property and an editable text description.

class Marker() {
  constructor(vnode) {
    this.time = vnode.attrs.time
    this.text = vnode.attrs.text
  }
  view(vnode) {
    return m('.marker', {time: this.time}, [
      m('.marker_text', this.text)
    ])
  }
}

Markers will be instantiated on clips.
src/Clip.js

m.request('/markers/' + this.filename).then( (m) => {
  this.markers = m
}

marker information, is pulled from api:

@app.get('/markers/{filename}')
def get_markers(filename: str):
    # get list of markers
    return markers

@subcontrabass subcontrabass added the enhancement ➕ New feature or request label Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ➕ New feature or request
Projects
No open projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants