Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly detect a global sidebar and not a specific page sidebar #9966

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Correctly detect a global sidebar and not a specific page sidebar #9966

wants to merge 7 commits into from

Commits on Jun 12, 2024

  1. global sidebard is detected by undefined id, so we need to compute … 

    …id from title not too early, and in a a way that does not modify initial config

From unmerged #8871 to deal with #8869 and follow up on #5689

Closes #9242 and closes #9728
    @cderv
    cderv committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    2c0c7aa View commit details
    Browse the repository at this point in the history

  2. Explicitly mark the clone as Sidebar arry type

    @cderv
    cderv committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    27f0894 View commit details
    Browse the repository at this point in the history

  3. Add test for initial fix 

    A sidebar item with only single id should apply only to this one

Related to #5689
    @cderv
    cderv committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    554f7d8 View commit details
    Browse the repository at this point in the history

  4. Move the tests to smoke-all

    @cderv
    cderv committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    ba364cb View commit details
    Browse the repository at this point in the history

  5. Add another about sidebar title 

    Based on #9242
    @cderv
    cderv committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    7783f28 View commit details
    Browse the repository at this point in the history

  6. Add one more tests about sidebar 

    Related to #8869
    @cderv
    cderv committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    f3e04ba View commit details
    Browse the repository at this point in the history

  7. Add to changelog 

    [skip ci]
    @cderv
    cderv committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    d5edb79 View commit details
    Browse the repository at this point in the history