Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly detect a global sidebar and not a specific page sidebar #9966

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Jun 12, 2024

This PR is a follow-up on #9741


Original Description

global sidebard is detected by undefined id, so we need to compute id from title not too early, and in a a way that does not modify initial config


This is currently a proposal built on top of unmerged #8871 by @dragonstyle to deal with #8869 and follow up on #5689

I believe we can do what was supposed to be done in #8871, but we need to make sure that we don't modify initial navigation.sidebars content's id.

I still think we could consider adding a more explicit global config for true or false to make this more clear.

This requires some testing to be sure it works ok this time. Opening this draft PR to discuss and have thoughts on this change.


New consideration

This PR broke complex website like Quarto web. So this type of change needs to be tested against very complex usage of sidebar.
So the implicit global sidebar detection is still not working - maybe adding a new global config kye is better than considering id to be undefined as a global sidebar.

Opening as a draft to remember work done, and try again later.

TO DO

…id from title not too early, and in a a way that does not modify initial config

From unmerged #8871 to deal with #8869 and follow up on #5689

Closes #9242 and closes #9728
A sidebar item with only single id should apply only to this one

Related to #5689
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants