Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Use non-lazy AST traversal for filters when possible #11052

Draft
wants to merge 41 commits into
base: main
Choose a base branch
from
Draft

perf: Use non-lazy AST traversal for filters when possible #11052

wants to merge 41 commits into from

Commits on Nov 19, 2024

  1. Add jog Lua module

    @tarleb
    tarleb committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    bf4ea8a View commit details
    Browse the repository at this point in the history

  2. Use jog instead of walk

    @tarleb
    tarleb committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    a06432b View commit details
    Browse the repository at this point in the history

  3. Force use of pandoc walk for some filters

    @tarleb
    tarleb committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    2fefec0 View commit details
    Browse the repository at this point in the history

  4. Add mechanism to check jog results 

    Setting the `QUARTO_JOG_CHECK` environment variable will run checks to
identify filters for which the results of `jog` differ from those of
pandoc's `walk`.
    @tarleb
    tarleb committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    6e725bf View commit details
    Browse the repository at this point in the history

  5. Make jog more forgiving 

    This should be reversed at some point.
    @tarleb
    tarleb committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    7d4f51d View commit details
    Browse the repository at this point in the history

  6. Add attribute checks

    @tarleb
    tarleb committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    35d1bbc View commit details
    Browse the repository at this point in the history

  7. Rely less on pandoc's type implicit conversions

    @tarleb
    tarleb committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    756a355 View commit details
    Browse the repository at this point in the history

  8. Prevent unintended side-effects of filter functions

    @tarleb
    tarleb committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    85eab47 View commit details
    Browse the repository at this point in the history

  9. table-rawhtml: destructively modify the input list 

    Minor performance improvement.
    @tarleb
    tarleb committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    5f9f89b View commit details
    Browse the repository at this point in the history

  10. lightbox: Restart imgCount each time the filter is invoked. 

    This allows to get reproducible output when running the filter multiple
times.
    @tarleb
    tarleb committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    2df4c1b View commit details
    Browse the repository at this point in the history

  11. Allow checks for inadvertent AST modifications 

    This check is enabled when the QUARTO_JOG_CHECK environment variable is
set.
    @tarleb
    tarleb committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    73ff5aa View commit details
    Browse the repository at this point in the history

  12. Always use jog, except for user-filters 

    This reverts commit 1040555.
    @tarleb
    tarleb committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    53fd9f8 View commit details
    Browse the repository at this point in the history

  13. Use jog for more filters 

    Some filters still don't work with jog.
This reverts most of commit f07e82077693c16132d63d9fb5fb0555ff3e8532.
    @tarleb
    tarleb committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    e19df02 View commit details
    Browse the repository at this point in the history

  14. [REVIEW REQUIRED] Return modified meta object from init filter

    @tarleb
    tarleb committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    cc7d692 View commit details
    Browse the repository at this point in the history

  15. [WIP] Cleanup parsefiguredivs filters

    @tarleb
    tarleb committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    51c8800 View commit details
    Browse the repository at this point in the history

  16. Make jog more robust when traversing topdown 

    The filter result might have a different type than the original element,
so the type must be retrieved again.
    @tarleb
    tarleb committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    7bbcf7c View commit details
    Browse the repository at this point in the history

  17. Ensure proper types in Meta objects

    @tarleb
    tarleb committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    260accd View commit details
    Browse the repository at this point in the history

  18. Use proper metadata types when resolving dependencies

    @tarleb
    tarleb committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    5b66cab View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Better type checking for meta values

    @tarleb
    tarleb committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    139faac View commit details
    Browse the repository at this point in the history

  2. Enable attribute checks only if QUARTO_JOG_CHECK is set

    @tarleb
    tarleb committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    d7dfc72 View commit details
    Browse the repository at this point in the history

  3. Enable "jog" debugging in smoke tests

    @tarleb
    tarleb committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    13de165 View commit details
    Browse the repository at this point in the history

  4. Ensure that the internal Meta copy is a true, deep copy

    @tarleb
    tarleb committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    2b98677 View commit details
    Browse the repository at this point in the history

  5. More MetaValue typecheck fixes

    @tarleb
    tarleb committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    c23f32d View commit details
    Browse the repository at this point in the history

  6. Allow to pass extra info to conversion warner

    @tarleb
    tarleb committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    488a7cf View commit details
    Browse the repository at this point in the history

  7. Fix MetaValue conversions for empty Lists

    @tarleb
    tarleb committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    4643a27 View commit details
    Browse the repository at this point in the history

  8. [FIXME] This fixes things. I have no idea why

    @tarleb
    tarleb committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    bb711e0 View commit details
    Browse the repository at this point in the history

  9. Don't add number values to the metadata object

    @tarleb
    tarleb committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    598180c View commit details
    Browse the repository at this point in the history

  10. attribcheck: improve robustness of warn function

    @tarleb
    tarleb committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    56898c1 View commit details
    Browse the repository at this point in the history

  11. Fix crash when checking Meta values for mutations

    @tarleb
    tarleb committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    57ea8f3 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Custom nodes: cleanup code for slots/forwarder

    @tarleb
    tarleb committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    dac3b25 View commit details
    Browse the repository at this point in the history

  2. Fix type of return value in typst filter function

    @tarleb
    tarleb committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    5c4c6d0 View commit details
    Browse the repository at this point in the history

  3. Attribcheck: Export type checker function

    @tarleb
    tarleb committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    e94c194 View commit details
    Browse the repository at this point in the history

  4. Jog check: Validate Meta types after each emulated filter

    @tarleb
    tarleb committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    759d275 View commit details
    Browse the repository at this point in the history

  5. Fix type confusion in crossref code

    @tarleb
    tarleb committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    af3e1b0 View commit details
    Browse the repository at this point in the history

  6. Add type-checking for some Cell attributes

    @tarleb
    tarleb committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    9e3a4a2 View commit details
    Browse the repository at this point in the history

  7. Fix copy table

    @tarleb
    tarleb committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    b1f23d2 View commit details
    Browse the repository at this point in the history

  8. Error out on failed attribute type checks

    @tarleb
    tarleb committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    c52787c View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Accomodate jog and attrcheck to pandoc dev version

    @tarleb
    tarleb committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    0ef5b59 View commit details
    Browse the repository at this point in the history

  2. Fix type in Caption

    @tarleb
    tarleb committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    307aff4 View commit details
    Browse the repository at this point in the history

  3. Fix more caption types

    @tarleb
    tarleb committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    4fb1c0a View commit details
    Browse the repository at this point in the history

  4. [FIXME] Just want to try if this works

    @tarleb
    tarleb committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    8b4d18a View commit details
    Browse the repository at this point in the history