Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review: isSubdir #11454

Open
cscheid opened this issue Nov 15, 2024 · 0 comments
Open

Code review: isSubdir #11454

cscheid opened this issue Nov 15, 2024 · 0 comments
Assignees
Labels
early-in-release An issue that should be worked on early in the release (likely due to risk) maintenance
Milestone

Comments

@cscheid
Copy link
Collaborator

cscheid commented Nov 15, 2024

We currently vendor isSubdir from Deno's stdlib, and their documentation (or code, take your pick) describes parameters src and dest precisely backward. We use this call in Quarto ourselves: https://github.com/quarto-dev/quarto-cli/blob/main/src/deno_ral/fs.ts#L49. We need to review all callers of this function for accuracy, and then fix the function code or docs.

@cscheid cscheid self-assigned this Nov 15, 2024
@cscheid cscheid added this to the v1.7 milestone Nov 15, 2024
@cscheid cscheid added maintenance early-in-release An issue that should be worked on early in the release (likely due to risk) labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
early-in-release An issue that should be worked on early in the release (likely due to risk) maintenance
Projects
None yet
Development

No branches or pull requests

1 participant