Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabric8 - many (130+) dependencies in generated BOM #44810

Open
rsvoboda opened this issue Nov 28, 2024 · 3 comments
Open

Fabric8 - many (130+) dependencies in generated BOM #44810

rsvoboda opened this issue Nov 28, 2024 · 3 comments
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/kubernetes

Comments

@rsvoboda
Copy link
Member

Description

Our generated BOM contains a many (130+) io.fabric8-related dependencies in the BOM.

While Guillaume did some work to reduce the cost of this in the Maven resolve, there's still a cost associated to it. I'm wondering if we should be a bit more careful about it.

There are several areas of fabri8 artifacts that might not be needed, e.g. artifact ending with -examples or -tests, some models and integrations (e.g. volcano doesn't seem to be used in quarkus / quarkiverse)

Note that the answer might very well be yes we need to keep all of them but I wanted to make sure we are aware of the situation.

See generated BOM here: https://central.sonatype.com/artifact/io.quarkus/quarkus-bom .

And search for <groupId>io.fabric8</groupId>, there are 131 hits atm.

Whole kubernetes-client-bom is imported in https://github.com/quarkusio/quarkus/blob/main/bom/application/pom.xml#L375 now

            <!-- Kubernetes-client dependencies, imported as a BOM -->
            <dependency>
                <groupId>io.fabric8</groupId>
                <artifactId>kubernetes-client-bom</artifactId>
                <version>${kubernetes-client.version}</version>
                <type>pom</type>
                <scope>import</scope>
            </dependency>

This is inspired by #44771 issue created by @gsmet

Implementation ideas

No response

@rsvoboda rsvoboda added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Nov 28, 2024
Copy link

quarkus-bot bot commented Nov 28, 2024

/cc @geoand (kubernetes), @iocanel (kubernetes)

@geoand
Copy link
Contributor

geoand commented Nov 28, 2024

cc @manusa @metacosm

@rsvoboda rsvoboda changed the title fabric8 - many (130+) dependencies in generated BOM Fabric8 - many (130+) dependencies in generated BOM Nov 28, 2024
@manusa
Copy link
Contributor

manusa commented Nov 28, 2024

I created the following issues to deal with the problem upstream:

Additional polishing and wiring can also be done at the Quarkus level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/kubernetes
Projects
None yet
Development

No branches or pull requests

3 participants