Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make WireMock extension for Quarkus an official Dev Service #70

Open
2 of 3 tasks
oleg-nenashev opened this issue Nov 24, 2023 · 21 comments
Open
2 of 3 tasks

Make WireMock extension for Quarkus an official Dev Service #70

oleg-nenashev opened this issue Nov 24, 2023 · 21 comments

Comments

@oleg-nenashev
Copy link

oleg-nenashev commented Nov 24, 2023

Congrats with the 1.0.0 release @chberger !

This extension looks like a Dev Service, smells like a DevService, and also behaves and gets configured as a Dev Service. But formally it is not one at the moment. It would be great to make it more official and have it listed on https://quarkus.io/guides/dev-services and within the Quarkus app.

I'd be happy to help with documentation and whatever needed for it

Proposal

Quarkus Dev UI

Right now the extension is not listed as a dev service

image

image

@chberger
Copy link
Contributor

Hi @oleg-nenashev, many thanks! 🚀

I really like your proposal! 👍 However, I'm not sure whether the Quarkus team will actually list external Dev Services in their guides. I have the impression that all Dev Services currently mentioned are part of the core platform.

Anyway, feel free to get in touch with the Quarkus team. Maybe it is actually conceivable ... 🤞

Regarding your last point I've created a PR which addresses this issue: #72. I would be delighted if you would review it.

@oleg-nenashev
Copy link
Author

oleg-nenashev commented Nov 25, 2023

Cc @maxandersen @aloubyansky for the dev service criteria. On behalf of the WireMock community, would be happy to cooperate on that

@maxandersen
Copy link
Member

We already have neo4j listed.

If gets to be issue we'll fix it and make it work.

@holly-cummins
Copy link

I've raised quarkusio/quarkusio.github.io#1869 for a discussion of listing more dev services on https://quarkus.io/guides/dev-services.

@oleg-nenashev
Copy link
Author

Hi @chberger could you please send me your contact email address (my one is public in the profile - o.v.nenashev at gmail dot com)? I would like to add you directly to the email conversation with @holly-cummins that we started on this subject

Copy link

@chberger This is being labeled as stale.

@github-actions github-actions bot added the Stale label Mar 17, 2024
Copy link

@chberger This is being closed due to inactivity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 24, 2024
@oleg-nenashev
Copy link
Author

@chberger could you please reopen it?

@chberger chberger removed the Stale label Mar 25, 2024
@chberger chberger reopened this Mar 25, 2024
@chberger
Copy link
Contributor

@oleg-nenashev thanks for the hint

@holly-cummins
Copy link

@holly-cummins
Copy link

Oh, and I thought I already commented, but I can't find it, so maybe not. As a general terminology clarification, a dev service is just the ability to start a zero-configuration container; some extensions do, and some don't. It's not a description of extension status or something extensions get nominated to be.

@phillip-kruger
Copy link
Member

phillip-kruger commented Apr 5, 2024

@holly-cummins yes that should happen automatically. As long as they produce io.quarkus.deployment.dev.devservices.DevServiceDescriptionBuildItem. See https://github.com/quarkusio/quarkus/blob/c24cfd708ba71c285b0b7459ee2e5956124e3b7b/extensions/vertx-http/deployment/src/main/java/io/quarkus/devui/deployment/menu/DevServicesProcessor.java#L27

@holly-cummins
Copy link

holly-cummins commented Apr 6, 2024

Thanks, @phillip-kruger! I can see the dev services description build item in the code, so I guess the next thing is to confirm if the dev service is still missing from the UI.

I've just checked (sorry, I should have done that before asking you, @phillip-kruger!), and I can see it in my dev UI:

image

@oleg-nenashev, is it still missing for you?

@oleg-nenashev
Copy link
Author

@holly-cummins it was added by @chberger in 1.1.0 - #72 . Sorry, this ticket is a bit dated, will update

@holly-cummins
Copy link

See https://quarkus.io/version/main/guides/dev-services for the new guide content. So I think it's just mentioning the extension in https://quarkus.io/guides/getting-started-testing which is outstanding.

Copy link

@chberger This is being labeled as stale.

@github-actions github-actions bot added the Stale label Jun 26, 2024
@oleg-nenashev
Copy link
Author

Not stale but still needs a few steps

@chberger chberger removed the Stale label Jun 26, 2024
Copy link

@chberger This is being labeled as stale.

@github-actions github-actions bot added the Stale label Aug 26, 2024
@holly-cummins
Copy link

The one outstanding item for this item is adding something to https://quarkus.io/guides/getting-started-testing. I never know exactly how much the guides should be about the core/platform, and how much they should include the whole Quarkiverse, but independently of that question, this bit in the guide seems definitely wrong:

Common cases include starting docker containers using Testcontainers (an example of which can be found here), or starting a mock HTTP server using Wiremock (an example of which can be found here).

We wouldn't expect people to use a test resource for WireMock, because there's an extension. So the text wants changing, maybe to find a different example of user-managed resources. And @geoand, I wonder if the code example should be updated?

@geoand
Copy link
Contributor

geoand commented Aug 27, 2024

Yeah, we can definitely update that

@github-actions github-actions bot removed the Stale label Aug 28, 2024
@wjglerum
Copy link
Contributor

I proposed to add a little more information for the Wiremock dev ui card here #180

If you have any other thoughts or additions let me know 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants