Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Release Workflow #275

Closed
gastaldi opened this issue Sep 18, 2024 · 3 comments
Closed

New Release Workflow #275

gastaldi opened this issue Sep 18, 2024 · 3 comments
Assignees

Comments

@gastaldi
Copy link
Member

gastaldi commented Sep 18, 2024

The release.yml workflows in each repository should be updated to the following content:

release-prepare.yaml

name: Quarkiverse Release

on:
  pull_request:
    types: [ closed ]
    paths:
      - '.github/project.yml'

concurrency:
  group: ${{ github.workflow }}-${{ github.ref }}
  cancel-in-progress: true

jobs:
  prepare-release:
    name: Prepare Release
    if: ${{ github.event.pull_request.merged == true}}
    uses: quarkiverse/.github/.github/workflows/prepare-release.yml@main
    secrets: inherit

release-perform.yaml

name: Quarkiverse Perform Release
run-name: Perform ${{github.event.inputs.tag || github.ref_name}} Release
on:
  push:
    tags:
      - '*'
  workflow_dispatch:
    inputs:
      tag:
        description: 'Tag to release'
        required: true

concurrency:
  group: ${{ github.workflow }}-${{ github.ref }}
  cancel-in-progress: true

jobs:
  perform-release:
    name: Perform Release
    uses: quarkiverse/.github/.github/workflows/perform-release.yml@main
    secrets: inherit
    with:
      version: ${{github.event.inputs.tag || github.ref_name}}

pre-release.yaml

name: Quarkiverse Pre Release

on:
  pull_request:
    paths:
      - '.github/project.yml'

concurrency:
  group: ${{ github.workflow }}-${{ github.ref }}
  cancel-in-progress: true

jobs:
  pre-release:
    name: Pre-Release
    uses: quarkiverse/.github/.github/workflows/pre-release.yml@main
    secrets: inherit

This gives us the flexibility to adapt the release workflow as it's reusable by all Quarkiverse repositories, including, but not limited to, allowing the usage of protected branches during the release

@gastaldi gastaldi self-assigned this Sep 18, 2024
@ppalaga

This comment was marked as outdated.

@ppalaga
Copy link
Contributor

ppalaga commented Sep 18, 2024

Otherwise nice, esp. the trick with having a special job for uploading to central, so that quarkiverse contributors cannot steal the credentials.

@gastaldi

This comment was marked as outdated.

This was referenced Oct 11, 2024
This was referenced Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants