Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy insufficiently strict? #1349

Open
fdmalone opened this issue Aug 27, 2024 · 2 comments
Open

mypy insufficiently strict? #1349

fdmalone opened this issue Aug 27, 2024 · 2 comments
Labels
Milestone

Comments

@fdmalone
Copy link
Collaborator

fdmalone commented Aug 27, 2024

#1345 fixed a bug with PrepareIdentity being constructed with a tuple of QDTypes when it expects a Tuple of Registers. It's surprising mypy didn't catch this. The issue is to figure out why this was allowed.

@mpharrigan
Copy link
Collaborator

some reference docs: https://www.attrs.org/en/stable/types.html

could it be because sometimes the fields use field() and sometimes use type annotations?

@fdmalone
Copy link
Collaborator Author

maybe missing the "type" argument to field?

@mpharrigan mpharrigan added this to the After v1.0 milestone Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants