Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion of XTKS (JPX) holidays #164

Open
rsheftel opened this issue Sep 16, 2020 · 1 comment
Open

Discussion of XTKS (JPX) holidays #164

rsheftel opened this issue Sep 16, 2020 · 1 comment
Labels

Comments

@rsheftel
Copy link
Collaborator

@gerrymanoim I don't see the XKTS (JPX) calendar in your difference report, but doing a spot check the holiday 2021-09-23, the Autumnal Equinox (as shown here: https://www.tradinghours.com/exchanges/jpx/market-holidays/2021) is a holiday in pandas_market_calendars but not in trading_calendars

These holidays were provided to pandas_market_calendars in this PR: rsheftel/pandas_market_calendars#72

@gerrymanoim
Copy link
Collaborator

Hey @rsheftel - I actually didn't compare anything past the end of 2020, since we haven't gone through and updated all the calendars for 2021 (@jmccorriston and I have it as a todo list item).

The equinoxes are defined at https://github.com/quantopian/trading_calendars/blob/master/trading_calendars/xtks_holidays.py#L87. We can/should port over the 2021 holidays though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants