-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canvas chart layouts (broken/incomplete) #3310
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This PR is in bad shape, and doesn't even pass typescript checks right now, but I want to preserve it, just in case.
It includes:
ReactCanvas
)(1) is tolerable, but turned out to be too clunky in some places.
(3) is promising, but polishing it would take too much time: it's not obvious where to use
useEffect
and where touseLayoutEffect
, and the separation between layout stage where we calculate positions and sizes, and drawing stage, is a hard problem.