Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing logic for type variable binding? #56

Closed
nsbgn opened this issue Oct 31, 2021 · 2 comments
Closed

Missing logic for type variable binding? #56

nsbgn opened this issue Oct 31, 2021 · 2 comments

Comments

@nsbgn
Copy link
Contributor

nsbgn commented Oct 31, 2021

Why is the following not a part of TypeVariable.above() and TypeVariable.below()?

 if upper == lower:
        self.bind(upper())
@nsbgn
Copy link
Contributor Author

nsbgn commented Dec 11, 2021

Should be:

        if a.upper and a.upper == a.lower and a.upper is not None:
            self.bind(a.upper())

Would otherwise cause errors. Rest of point stands.

@nsbgn
Copy link
Contributor Author

nsbgn commented May 16, 2022

With the new constraint logic (#85) this actually leads to a practical issue, so it will be included.

nsbgn added a commit that referenced this issue May 17, 2022
@nsbgn nsbgn closed this as completed May 17, 2022
nsbgn added a commit that referenced this issue May 17, 2022
This time for real, with MWE. See 9d78bc0 for initial commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant