Delayed-Join channel member is revealed even if the message is blocked +T

[DasBrain]

Currently client_can_send_to_channel is called first - and reveals the channel member, even if the message is later blocked by channel mode +T (MODE_NOMULTITARGET).

client_can_send_to_channel is called here:
https://github.com/quakenet/snircd/blob/master/ircd/ircd_relay.c#L102
+T is checked here:
https://github.com/quakenet/snircd/blob/master/ircd/ircd_relay.c#L110

Suggested fix:
Check for +T first.

[retropc]

it's a bit naughty that a function called client_can_send_to_channel mutates state

[retropc]

most of the other channel modes share the same bug, common with upstream: https://github.com/UndernetIRC/ircu2/blob/u2_10_12_branch/ircd/ircd_relay.c#L102

[DasBrain]

For MODE_NOPRIVMSGS (+n), it doesn't matter - if it is denied, the user is not on the channel.
MODE_NOCOLOR and MODE_NOCTCP should be checked first.

And I agree - it took me a while to find the place where delay-join got removed, because I did not suspect client_can_send_to_channel to mutate state.
(If I could/have to rename it, I would name it client_prepare_send_to_channel.)