From 74a87ac7e0bdc462187d1fe1b0f09ee2eee42268 Mon Sep 17 00:00:00 2001
From: Serwan Asaad <serwan.asaad@quantum-machines.co>
Date: Thu, 22 Feb 2024 11:04:00 +0100
Subject: [PATCH] add channel.frame_rotation

---
 quam/components/channels.py | 39 ++++++++++++++++++++++++++++++++++++-
 1 file changed, 38 insertions(+), 1 deletion(-)

diff --git a/quam/components/channels.py b/quam/components/channels.py
index 1acb3843..a55101e9 100644
--- a/quam/components/channels.py
+++ b/quam/components/channels.py
@@ -7,7 +7,17 @@
 from quam.utils import string_reference as str_ref
 
 
-from qm.qua import align, amp, play, wait, measure, dual_demod, declare, fixed
+from qm.qua import (
+    align,
+    amp,
+    play,
+    wait,
+    measure,
+    dual_demod,
+    declare,
+    fixed,
+    frame_rotation,
+)
 from qm.qua._dsl import (
     _PulseAmp,
     AmpValuesType,
@@ -269,6 +279,33 @@ def align(self, *other_elements):
             ]
             align(self.name, *other_elements_str)
 
+    def frame_rotation(self, angle: QuaNumberType):
+        r"""Shift the phase of the channel element's oscillator by the given angle.
+
+        This is typically used for virtual z-rotations.
+
+        Note:
+            The fixed point format of QUA variables of type fixed is 4.28, meaning the
+            phase must be between $-8$ and $8-2^{28}$. Otherwise the phase value will be
+            invalid. It is therefore better to use `frame_rotation_2pi()` which avoids
+            this issue.
+
+        Note:
+            The phase is accumulated with a resolution of 16 bit.
+            Therefore, *N* changes to the phase can result in a phase (and amplitude)
+            inaccuracy of about :math:`N \cdot 2^{-16}`. To null out this accumulated
+            error, it is recommended to use `reset_frame(el)` from time to time.
+
+        Args:
+            angle (Union[float, QUA variable of type fixed]): The angle to
+                add to the current phase (in radians)
+            *elements (str): a single element whose oscillator's phase will
+                be shifted. multiple elements can be given, in which case
+                all of their oscillators' phases will be shifted
+
+        """
+        frame_rotation(angle, self.name)
+
     def _config_add_controller(
         self, config: Dict[str, dict], controller_name: str
     ) -> Dict[str, dict]: