New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor error #101

Open

exadeci opened this issue Jun 3, 2015 · 1 comment

Labels

bug

Contributor

exadeci commented Jun 3, 2015

s3/lib/s3/connection.rb

Line 67 in 386361c

if params

Should be:

    if params.present?
      params = params.is_a?(String) ? params : self.class.parse_params(params)
      path << "?#{params}"
    end

Because it adds a "?" on every request.

The text was updated successfully, but these errors were encountered:

Collaborator

arthurnn commented Jun 3, 2015

fell free to open a PR, with a regression test to illustrate the bug.

qoobaa added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment