Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import coherentstate, thermalstate, displace, squeeze, wigner from QuantumInterface #175

Open
Krastanov opened this issue Sep 8, 2024 · 2 comments

Comments

@Krastanov
Copy link
Collaborator

Now that qojulia/QuantumInterface.jl#29 is merged, it would make sense to rely on that namespace for these helper functions.

@Krastanov
Copy link
Collaborator Author

ping @apkille

@apkille
Copy link
Contributor

apkille commented Sep 9, 2024

@Krastanov we get type piracy doing this, as the first four functions you mentioned dispatch on FockBasis, which is defined in QuantumInterface rather than QuantumOpticsBase. I missed this because FockBasis is not imported in the root file of QOBase and I was quick to assume it was defined somewhere in the package. Any ideas for fixing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants