From b7684f71458bffa26feebab16cd97947fa3702ad Mon Sep 17 00:00:00 2001 From: Stefan Krastanov Date: Tue, 4 Apr 2023 13:05:03 -0400 Subject: [PATCH] JET CI fixes (#84) * JET CI fixes * CI workflow improvements * switch JET CI to use not-nightly --- .github/dependabot.yml | 8 ++++++++ .github/workflows/CompatHelper.yml | 19 +++++-------------- .github/workflows/breakage.yml | 4 ++-- .github/workflows/ci-jet.yml | 10 +++++----- .github/workflows/ci.yml | 6 +++--- .github/workflows/docs.yml | 2 +- src/operators.jl | 2 +- test/test_jet.jl | 2 +- 8 files changed, 26 insertions(+), 27 deletions(-) create mode 100644 .github/dependabot.yml diff --git a/.github/dependabot.yml b/.github/dependabot.yml new file mode 100644 index 00000000..fbaca6ff --- /dev/null +++ b/.github/dependabot.yml @@ -0,0 +1,8 @@ + +# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates +version: 2 +updates: + - package-ecosystem: "github-actions" + directory: "/" # Location of package manifests + schedule: + interval: "weekly" \ No newline at end of file diff --git a/.github/workflows/CompatHelper.yml b/.github/workflows/CompatHelper.yml index 688c5c4c..83ab45da 100644 --- a/.github/workflows/CompatHelper.yml +++ b/.github/workflows/CompatHelper.yml @@ -1,25 +1,16 @@ name: CompatHelper on: schedule: - - cron: 0 0 * * * + - cron: '00 00 * * *' workflow_dispatch: jobs: CompatHelper: runs-on: ubuntu-latest steps: - - name: "Install CompatHelper" - run: | - import Pkg - name = "CompatHelper" - uuid = "aa819f21-2bde-4658-8897-bab36330d9b7" - version = "3" - Pkg.add(; name, uuid, version) - shell: julia --color=yes {0} - - name: "Run CompatHelper" - run: | - import CompatHelper - CompatHelper.main() - shell: julia --color=yes {0} + - name: Pkg.add("CompatHelper") + run: julia -e 'using Pkg; Pkg.add("CompatHelper")' + - name: CompatHelper.main() env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} COMPATHELPER_PRIV: ${{ secrets.DOCUMENTER_KEY }} + run: julia -e 'using CompatHelper; CompatHelper.main()' \ No newline at end of file diff --git a/.github/workflows/breakage.yml b/.github/workflows/breakage.yml index e91661b4..5d63c92e 100644 --- a/.github/workflows/breakage.yml +++ b/.github/workflows/breakage.yml @@ -20,14 +20,14 @@ jobs: pkgversion: [latest] steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 # Install Julia - uses: julia-actions/setup-julia@v1 with: version: 1 arch: x64 - - uses: actions/cache@v1 + - uses: actions/cache@v3 env: cache-name: cache-artifacts with: diff --git a/.github/workflows/ci-jet.yml b/.github/workflows/ci-jet.yml index 499e0a4b..c80577ea 100644 --- a/.github/workflows/ci-jet.yml +++ b/.github/workflows/ci-jet.yml @@ -11,18 +11,18 @@ jobs: fail-fast: false matrix: version: - - nightly + - '1' os: - ubuntu-latest arch: - x64 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - uses: julia-actions/setup-julia@v1 with: version: ${{ matrix.version }} arch: ${{ matrix.arch }} - - uses: actions/cache@v1 + - uses: actions/cache@v3 env: cache-name: cache-artifacts with: @@ -35,8 +35,8 @@ jobs: - uses: julia-actions/julia-buildpkg@v1 - uses: julia-actions/julia-runtest@v1 env: - QUANTUMSAVORY_JET_TEST: true + QUANTUMOPTICS_JET_TEST: true - uses: julia-actions/julia-processcoverage@v1 - - uses: codecov/codecov-action@v1 + - uses: codecov/codecov-action@v3 with: file: lcov.info diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4a3a7fa2..02b2a3a2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,12 +23,12 @@ jobs: - os: macOS-latest arch: x86 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - uses: julia-actions/setup-julia@v1 with: version: ${{ matrix.version }} arch: ${{ matrix.arch }} - - uses: actions/cache@v1 + - uses: actions/cache@v3 env: cache-name: cache-artifacts with: @@ -41,6 +41,6 @@ jobs: - uses: julia-actions/julia-buildpkg@v1 - uses: julia-actions/julia-runtest@v1 - uses: julia-actions/julia-processcoverage@v1 - - uses: codecov/codecov-action@v1 + - uses: codecov/codecov-action@v3 with: file: lcov.info diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index 227d5b46..e86cd0ee 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -13,7 +13,7 @@ jobs: build: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - uses: julia-actions/setup-julia@latest with: version: '1' diff --git a/src/operators.jl b/src/operators.jl index 0e2a9d52..f4a6b484 100644 --- a/src/operators.jl +++ b/src/operators.jl @@ -215,7 +215,7 @@ function embed(basis_l::CompositeBasis, basis_r::CompositeBasis, start_indices_flat = [i[1] for i in indices] complement_indices_flat = Int[i for i=1:N if i ∉ indices_flat] operators_flat = AbstractOperator[] - if all([minimum(I):maximum(I);]==I for I in indices) + if all(([minimum(I):maximum(I);]==I)::Bool for I in indices) # type assertion to help type inference for i in 1:N if i in complement_indices_flat push!(operators_flat, identityoperator(T, S, basis_l.bases[i], basis_r.bases[i])) diff --git a/test/test_jet.jl b/test/test_jet.jl index 22cc8e75..f722711b 100644 --- a/test/test_jet.jl +++ b/test/test_jet.jl @@ -25,7 +25,7 @@ using LinearAlgebra, LRUCache, Strided, Dates, SparseArrays if get(ENV,"QUANTUMOPTICS_JET_TEST","")=="true" rep = report_package("QuantumOpticsBase"; report_pass=MayThrowIsOk(), # TODO have something more fine grained than a generic "do not care about thrown errors" - ignored_modules=( # TODO fix issues with these modules or report them upstrem + ignored_modules=( # TODO fix issues with these modules or report them upstream AnyFrameModule(LinearAlgebra), AnyFrameModule(LRUCache), AnyFrameModule(Strided),