Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path to metric for request latencies #12

Open
L7R7 opened this issue Jul 22, 2020 · 1 comment
Open

Add path to metric for request latencies #12

L7R7 opened this issue Jul 22, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@L7R7
Copy link

L7R7 commented Jul 22, 2020

It would be great to have a label at the http_request_duration_seconds metric. That would make it possible to measure latencies for the different paths independently without losing the ability to aggregate them easily.

What do you think? If you're interested (and if it's not super hard to implement) I could try to come up with a PR for that

@qnikst
Copy link
Owner

qnikst commented Aug 24, 2020

I like the idea. And I'm open to the PR's to wai-middleware-prometheus, I don't have strong opinion on how that package should work, so will happily accept solutions that solve problems for people. I find inability to add labels to the http_request_duration_seconds as a great problem.

@qnikst qnikst added the enhancement New feature or request label Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants