Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework histograms #10

Open
qnikst opened this issue Jun 5, 2020 · 0 comments
Open

Rework histograms #10

qnikst opened this issue Jun 5, 2020 · 0 comments
Labels
enhancement New feature or request prometheus-client

Comments

@qnikst
Copy link
Owner

qnikst commented Jun 5, 2020

Histogram should be implemented as a set of counters and work in constant space. Prometheus design has sacrificed many features (like dynamic range resolution) that histograms may have in order to allow fast implementation and it's a shame not to use that.

Open question here is a level of locking that we want to have here. Do we want to lock writers when gathering stat or not?
@qnikst qnikst added prometheus-client enhancement New feature or request labels Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request prometheus-client
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@qnikst