Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Refactor block tree and header repo #2255

Open
kamilsa opened this issue Oct 31, 2024 · 0 comments · May be fixed by #2286
Open

[Enhancement]: Refactor block tree and header repo #2255

kamilsa opened this issue Oct 31, 2024 · 0 comments · May be fixed by #2286
Assignees
@ErakhtinB
Labels
Storage
Milestone
Polkadot treasury...

Comments

@kamilsa
Copy link
Contributor

kamilsa commented Oct 31, 2024

Description

We have intersecting set of methods in BlockTree and BlockHeaderRepository. It is proposed to make BlockTree a child class of BlockHeaderRepository

Motivation

Get rid of dublicate code and messy logic in some places, where we use both BlockTree and BlockHeaderRepository classes

Additional context

No response

Are you planning to do it yourself in a pull request ?

No
@kamilsa kamilsa added this to the Polkadot treasury milestone 3 milestone Oct 31, 2024
@ErakhtinB ErakhtinB linked a pull request Nov 21, 2024 that will close this issue
Open
@ErakhtinB ErakhtinB linked a pull request Nov 21, 2024 that will close this issue
Block header repo removed #2286
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ErakhtinB ErakhtinB

Labels
Storage
Projects
None yet
Milestone
Polkadot treasury milestone 3
Development

Successfully merging a pull request may close this issue.

Block header repo removed qdrvm/kagome
2 participants
@kamilsa @ErakhtinB