Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max_optimization_threads: 0 doesn't disable indexing #66

Open
ffuugoo opened this issue Oct 19, 2023 · 2 comments
Open

max_optimization_threads: 0 doesn't disable indexing #66

ffuugoo opened this issue Oct 19, 2023 · 2 comments

Comments

@ffuugoo
Copy link

ffuugoo commented Oct 19, 2023

While running vector-db-benchmarks I've noticed that

  • we are updating the collection with max_optimization_threads: 0 before uploading points
  • and then once again with max_optimization_threads: 1 after upload is finished
  • I assume this is done to disable optimization/indexing during points upload
  • but I've noticed that max_optimization_threads: 0 doesn't disable indexing
    • I've disabled the max_optimization_threads: 1 request and had a collection fully indexed with max_optimization_threads: 0

If max_optimization_threads was intended to disable/enable indexing, then vector-db-benchmark can be updated to use indexing_threshold: 0 instead.

Screenshot

Notice indexed_vectors_count near the top and max_optimization_threads at the bottom.

Screenshot 2023-10-18 at 16 13 13
@ffuugoo
Copy link
Author

ffuugoo commented Oct 19, 2023

@generall Do we also want an issue in qdrant regarding max_optimization_threads: 0?

@KShivendu
Copy link
Member

KShivendu commented Jan 24, 2024

You're right about this @ffuugoo.

Will fix this in the next benchmarks run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants