Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue adding fastembed as dependency in poetry due to python requirement #21

Closed
michaelfeil opened this issue Oct 12, 2023 · 7 comments
Closed
Labels
dependencies Pull requests that update a dependency file

Comments

@michaelfeil
Copy link

Installing the current project: infinity_emb (0.0.2)

infinity_emb $poetry lock --no-update
Resolving dependencies... (0.1s)

The current project's Python requirement (>=3.10,<4.0) is not compatible with some of the required packages Python requirement:
  - fastembed requires Python >=3.8.0,<3.12, so it will not be satisfied for Python >=3.12,<4.0
[tool.poetry.dependencies]
python = ">=3.10,<4.0"
fastapi = "^0.103.2"
fastembed = {version = "^0.0.5", optional=true}
@michaelfeil
Copy link
Author

python = ">=3.8.0,<3.12"
Maybe this line causes the Python 3.12 issue?

@NirantK
Copy link
Contributor

NirantK commented Oct 16, 2023

ONNX Runtime does not support 3.12 and breaks for that — hence the lock for less than 3.12. We'll support 3.12 when ONNX Runtime does.

@NirantK NirantK added the dependencies Pull requests that update a dependency file label Oct 18, 2023
@michaelfeil
Copy link
Author

@NirantK I see just to confirm, you cannot write: python = ">=3.8.0,<4" because onnx forbids that?

What a shame, I thought poetry can auto-resolve this.

@NirantK
Copy link
Contributor

NirantK commented Nov 1, 2023

Yes, that sounds right. ONNX Runtime does not support 3.12, so Poetry does flag it as broken. I believe that's the desired behaviour for most Poetry use cases.

@generall
Copy link
Member

generall commented Jan 5, 2024

onnx issue for the reference microsoft/onnxruntime#18793

@FcoManueel
Copy link

The ONNX issue that was blocking support for Python version 3.12 has been now resolved: microsoft/onnxruntime#18814

@FcoManueel
Copy link

With #111 merged this issue seems to be ready to be closed as completed.

Thank you for your work @NirantK !

@NirantK NirantK closed this as completed Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

4 participants