Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map size as a function of phase #426

Open
maclariz opened this issue Feb 2, 2023 · 7 comments
Open

Map size as a function of phase #426

maclariz opened this issue Feb 2, 2023 · 7 comments
Labels
documentation-examples Consider making into a documentation example

Comments

@maclariz
Copy link

maclariz commented Feb 2, 2023

Just found that mapping a two phase material, the map extent is different if I map the majority phase - it covers the full scan area - to the minority - which only covers the area containing this phase. Thus the IPF maps have different sizes and this makes comparison hard. Any way round this?

@hakonanes
Copy link
Member

hakonanes commented Feb 2, 2023

Do you want to combine the maps into one array/plot? Or save images of different IPF maps but with the same shape?

One way to do the former is shown in the crystal map tutorial in cell number 61 (the color key is not important here).

To do the latter, I suggest to do a variant of the example in the tutorial, where you only fill the map points of one phase and pass the whole array to the whole crystal map plot method, i.e. not to the crystal map of one phase. Does that work for you?

@maclariz
Copy link
Author

maclariz commented Feb 2, 2023

Thanks @hakonanes . After various coding stupidities, I got this to work...

@hakonanes
Copy link
Member

Glad to hear it! Were any of my suggestions useful, or did you do something else? It might be an idea to turn your case into an example in the examples gallery.

Also, I wonder if it is possible to allow a full_shape parameter to CrystalMap.plot(), because the original shape after slicing (e.g. with CrystalMap["phase1"]) is still kept for internal use.

@maclariz
Copy link
Author

maclariz commented Feb 2, 2023

I basically did as per your suggestions, except:

  • I am mapping IPF x, y and z
  • Thus generated a list of 3 correct shape arrays of zeros
  • Then filled the appropriate spots for the second phase with the colours already defined.
  • Then plotted all three IPF maps using the whole map to define the area and these colour arrays to define the colours

As for making an example, my thoughts are "not yet" until the work is published. Anything that gets published using orix could also be made into an example. The first will be more of a methods paper about mapping of 2-phase titanium, doing crystallography with the results, and getting quantitatively interpretable results, which fit crystallographic theory, all with few nm step size, which is unprecedented for such 2-phase Ti alloys (which are typically studied with EPSD at much coarses step size, which is therefore insensitive to the very fine scale structures).

@maclariz
Copy link
Author

maclariz commented Feb 2, 2023

That should be fairly uncontroversial as it is on an alloy which is not too commercially sensitive and getting approval for publication should not be hard. Some of the other work will need more discussion as the alloy and heat treatment conditions are commercial and we would need permission to publish from the commercial partner.

@hakonanes
Copy link
Member

All understandable. Thank you for considering it.

We could at least make an example showing how to plot separate IPF maps of the full map shape to ease comparison, which was your issue. Any two-phase map will do in this case.

@hakonanes hakonanes added the documentation-examples Consider making into a documentation example label Feb 2, 2023
@maclariz
Copy link
Author

maclariz commented Feb 2, 2023

I agree. Would be nice to have the example on something where a given phase does not extend to the map edges in at least one direction, so that without doing this, you get different shaped maps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation-examples Consider making into a documentation example
Projects
None yet
Development

No branches or pull requests

2 participants