Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add functionality to export a JSON schema of PywrModel. #172

Merged
merged 1 commit into from
Apr 26, 2024
Merged

feat: Add functionality to export a JSON schema of PywrModel. #172

merged 1 commit into from
Apr 26, 2024

Conversation

jetuk
Copy link
Member

@jetuk jetuk commented Apr 25, 2024

Use the schemars crate to export a JSON schema via the CLI. This needs implementing for the remaining model types.

@jetuk
feat: Add functionality to export a JSON schema of PywrModel.
eb24131 
Use the schemars crate to export a JSON schema via the CLI. This
needs implementing for the remaining model types.
@jetuk jetuk requested a review from Batch21 April 25, 2024 10:57
Batch21
Batch21 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@Batch21 Batch21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did notice when looking at this that the schemars crate it not getting a lot of maintenance. Probably something to keep an eye on.

@jetuk jetuk merged commit 90e42b3 into main Apr 26, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Batch21 Batch21 Batch21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jetuk @Batch21