Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add soft min/max flow to LinkNode #181

Closed
jetuk opened this issue May 10, 2024 · 4 comments
Closed

Add soft min/max flow to LinkNode #181

jetuk opened this issue May 10, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@jetuk
Copy link
Member

jetuk commented May 10, 2024

Feature request to add ability for a soft minimum and/or maximum node. This feature could be added to the basic node types: Input, Link and Output. When active it would create an additional internal node for the soft min and/or max.

@jetuk jetuk added the enhancement New feature or request label May 10, 2024
@s-simoncelli
Copy link
Contributor

I started to implement this for a Link node. Do we want the node to look like this internally?

image

Or is it simpler to just set one soft constraint and the user decides whether it is a min or max?

@jetuk
Copy link
Member Author

jetuk commented Jun 26, 2024

I think the schematic is correct. I think you'll want it to only create the additional links if they are needed. It will probably be easier to keep them separated/dedicated for min and max for clarity and tracking (also if someone wants both?).

We'll need to ensure that the attributes correctly reflect these additional links.

@s-simoncelli
Copy link
Contributor

Ok, my first implementation is in #213

@jetuk
Copy link
Member Author

jetuk commented Oct 3, 2024

Completed in #213

@jetuk jetuk closed this as completed Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants