Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter name spaces #179

Closed
jetuk opened this issue May 7, 2024 · 0 comments · Fixed by #234
Closed

Add parameter name spaces #179

jetuk opened this issue May 7, 2024 · 0 comments · Fixed by #234
Labels
enhancement New feature or request

Comments

@jetuk
Copy link
Member

jetuk commented May 7, 2024

For cases where a parameter needs to be added as child of another parameter or node as part of "building" a model from a schema. The current approach requires making a unique global name which has issues with risking conflict and create horrible names.

We currently model this in nodes using "sub-names"; an optional unique identifier in the namespace of the parent node name. The same idea could work with parameters.

However, I wonder if it would make more sense to have an optional parent (and whether the nodes should be re-modelled in this manner also).

See also discussion in #107

@jetuk jetuk added the enhancement New feature or request label May 7, 2024
@jetuk jetuk mentioned this issue May 11, 2024
8 tasks
jetuk added a commit that referenced this issue Jul 30, 2024
Core Parameters can now be identified with an optional parent
string. This is helpful for creating Parameters in compound
nodes without risking naming conflicts with the user's own
parameter names.

Fixes #179.
jetuk added a commit that referenced this issue Aug 7, 2024
Core Parameters can now be identified with an optional parent
string. This is helpful for creating Parameters in compound
nodes without risking naming conflicts with the user's own
parameter names.

Fixes #179.
@jetuk jetuk closed this as completed in #234 Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant