Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subdomain redirect aliases for plzenske, olomoucke and more #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add subdomain redirect aliases for plzenske, olomoucke and more #150

wants to merge 1 commit into from

Conversation

torsava
Copy link
Contributor

@torsava torsava commented Aug 21, 2021

Also move the redirect aliases definition closer to the
BACKCOMPAT_SERIES_ALIASES.

Fixes: #91

@torsava
Add subdomain redirect aliases for plzenske, olomoucke and more
695fd02 
Also move the redirect aliases definition closer to the
BACKCOMPAT_SERIES_ALIASES.

Fixes: pyvec#91
@torsava
Copy link
Contributor Author

torsava commented Aug 21, 2021

Please note that I have not tested the subdomain redirects locally (messing with the DNS is not my forte).

@encukou
Copy link
Member

encukou commented Aug 21, 2023

Sorry for the delay.
I'm hesitant to merge this as-is for a few reasons:

  • IMO these should go in pyvo-data, so when a new city is added it gets the redirect.
  • These redirects prevent converting pyvo.cz to a static site on GH Pages :(
  • The subdomains don't have HTTPS, so I'd like to phase them out somehow

Should we say that perfect shouldn't be the enemy of the good, and merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plzenske. and olomoucke.pyvo.cz don't work
2 participants
@torsava @encukou