Bugfixes seviri l2 grib reader #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…read information to be passed on to the next eccodes instance.
…t. Use GEOFlippableFileYAMLReader instead of FileYAMLReader.
…ader to seviri_base such that the seviri_l2_grib reader can use the same method. Remove old method in seviri_base, previously used to compute the area extent for the grib files.
…e reader to seviri_base in order to have correct output also for segmented products. Add standardized area definitions for segmented SEVIRI L2 grib products.
…of correct magnitude. Needed until information in grib message for the aerosol over sea product has been fixed by EUMETSAT.
…re direct derivatives of the L15 channel data.
…ri_l2_grib reader.
strandgren
requested review from
adybbroe,
djhoese,
mraspaud and
sfinkens
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1920 +/- ##
==========================================
+ Coverage 93.39% 93.46% +0.07%
==========================================
Files 273 275 +2
Lines 40612 40735 +123
==========================================
+ Hits 37929 38074 +145
+ Misses 2683 2661 -22
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This purpose of this PR is to standardize the area definitions of the SEVIRI L2 grib products. During implementation three bugs were identified and resolved:
When looping over multiple grib files, information from a previously opened grib file would sometimes be passed on to the next call. This has been resolved by always lopping over all messages in the grib file, such that no additional information can be passed on. An issue for this unexpected behavior has been created in the python-ecCodes github (Unexpected behavior if not all GRIB messages in a file are read ecmwf/eccodes-python#58).
The computation of the area extent did not provide correct results for segmented products. The implementation used in the seviri_l1b_native reader is now used (the method has been moved to seviri_base to allow both reader to access it).
In the aerosol over sea product the Earth's minor axis is provided in the wrong unit (off by a factor 1e8). A work-around has been temporarily implemented that will make sure that all earth axis dimensions are of the correct magnitude. This work-around can be used until the issue has been resolved by EUMETSAT.