-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace stacking gradient search with resample_blocks variant #626
Replace stacking gradient search with resample_blocks variant #626
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #626 +/- ##
==========================================
- Coverage 93.97% 93.96% -0.01%
==========================================
Files 86 86
Lines 13848 13538 -310
==========================================
- Hits 13013 12721 -292
+ Misses 835 817 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of initial comments. I'll do some real-life testing next.
I'm surprised you could get rid of such a huge chunk of code!
Also, preliminary test, resampling that metop scene to euron1 takes 5GB on main vs 3GB with this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for a) fixing #620 and b) getting rid of huge amounts of code!
This PR replaces the stacking gradient search with resample blocks for the swath to area case.
It also adds support for area to swath in the gradient search.