-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tlefile.py seem to use satellite name rather than the international designator number #119
Comments
I copied the two lines to from pyorbital import tlefile
tle1 = tlefile.read('noaa-21', '/tmp/noaa21.tle') works. Note |
@pnuu Yes, I know, I found that later when working on #118 I commented in the code suggested for #118 But I think this could/should be better documented, perhaps even with some warning/info message saying that in this case we found something that seem to fit, but it isn't an exact fit, instead of just raising a I can try suggest a PR for this, modifying #118 I suggest, if you agree? |
Code Sample, a minimal, complete, and verifiable piece of code
I have two simple tle files like this:
and
And a
platforms.txt
file that contains NOAA-21, like this (in the latest Pyorbital release this files does not include NOAA-21):Problem description
The above code fails giving a KeyError, see below for a traceback.
I would have expected that when reading the TLE file the name of the satellite should not be used, but that Pyorbital exclusively goes by the designator number.
Worth mentioning that having a name consistent with what is listed in
platforms.txt
works (a dash in the platform name):tle2 = tlefile.read('noaa-21', '/path/to/tles/jpss2.tle'
Of relevance, the same error appears when reading the TLE file over internet (Spacetrack):
But doing
orb = Orbital("NOAA-21")
works. Consistent with the above.[this should also explain why the current behaviour is a problem and why the
expected output is a better solution.]
Expected Output
The above code should run without errors/exceptions
Actual Result, Traceback if applicable
Versions of Python, package at hand and relevant dependencies
Thank you for reporting an issue !
The text was updated successfully, but these errors were encountered: