Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different way to return position and velocity in astronomy and orbital #11

Open
rdbisme opened this issue Jan 20, 2017 · 1 comment
Open

Comments

@rdbisme
Copy link
Contributor

rdbisme commented Jan 20, 2017

Hello,

is there a reason why on pyorbital.astronomy.observer_position the position is given in terms of tuples while on pyorbital.orbital.Orbital.get_position is returned in terms of np.array?

I believe it would have been better to stick with same style. What do you think?

@mraspaud
Copy link
Member

The reason behind this is that when we started pyorbital, the use case was one observer, many satellite positions.

But you're right, it should be made consistent. Pull request is welcome 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants