Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing payment from Apple Pay in account_transactions.csv #149

Open
AiroPi opened this issue Dec 4, 2024 · 2 comments · May be fixed by #152
Open

Missing payment from Apple Pay in account_transactions.csv #149

AiroPi opened this issue Dec 4, 2024 · 2 comments · May be fixed by #152
Labels
bug Something isn't working

Comments

@AiroPi
Copy link

AiroPi commented Dec 4, 2024

Description of the bug
I am exporting my account transactions into a CSV, and my only (which is also my all first) transaction I made using Apple Pay doesn't appear on the CSV file.

To Reproduce
Use the command dl_docs.

Expected behavior
The transactions should appear in the CSV.

all_events.json
The transactions does appear in the all_events.json file :

{
    "id": "be84efa7-5c02-46de-ae19-9cbb452f00e6",
    "timestamp": "2023-11-12T13:10:40.492+0000",
    "title": "Einzahlung",
    "icon": "logos/bank_applepay/v2",
    "badge": null,
    "subtitle": null,
    "amount": {
      "currency": "EUR",
      "value": 100.0,
      "fractionDigits": 2
    },
    "subAmount": null,
    "status": "EXECUTED",
    "action": {
      "type": "timelineDetail",
      "payload": "be84efa7-5c02-46de-ae19-9cbb452f00e6"
    },
    "eventType": "PAYMENT_INBOUND_APPLE_PAY",
    "source": "timelineTransaction",
    "details": {
      "id": "be84efa7-5c02-46de-ae19-9cbb452f00e6",
      "sections": [
        {
          "title": "Du hast 100,00 € über Apple Pay hinzugefügt",
          "data": {
            "icon": "logos/bank_applepay/v2",
            "subtitleText": null,
            "timestamp": "2023-11-12T13:10:40.492+0000",
            "status": "executed"
          },
          "action": null,
          "type": "header"
        },
        {
          "title": "Übersicht",
          "data": [
            {
              "title": "Status",
              "detail": {
                "text": "Completed",
                "functionalStyle": "EXECUTED",
                "type": "status"
              },
              "style": "plain"
            },
            {
              "title": "Zahlung",
              "detail": {
                "text": "Apple Pay",
                "icon": "logos/bank_applepay/v2",
                "type": "iconWithText"
              },
              "style": "plain"
            }
          ],
          "action": null,
          "type": "table"
        },
        {
          "title": "Transaktion",
          "data": [
            {
              "title": "Gebühr",
              "detail": {
                "text": "0,00 €",
                "trend": null,
                "action": null,
                "type": "text"
              },
              "style": "plain"
            },
            {
              "title": "Betrag",
              "detail": {
                "text": "100,00 €",
                "trend": null,
                "action": null,
                "type": "text"
              },
              "style": "highlighted"
            }
          ],
          "action": null,
          "type": "table"
        },
        {
          "title": "Dokumente",
          "data": [
            {
              "title": "Abrechnung Einzahlung",
              "detail": "12.11.2023",
              "action": {
                "type": "browserModal",
                "payload": "[REDACTED]"
              },
              "id": "1f0a15fc-b7a9-4d45-a240-3b7f1d41b377",
              "postboxType": "PAYMENT_INBOUND_INVOICE",
              "local_filepath": "traderep2/Abrechnung Einzahlung/2023-11-12 Abrechnung Einzahlung - Einzahlung.pdf"
            }
          ],
          "action": null,
          "type": "documents"
        },
        {
          "title": "",
          "data": [
            {
              "title": "",
              "detail": {
                "icon": "",
                "action": {
                  "type": "customerSupportChat",
                  "payload": {
                    "contextParams": {
                      "chat_flow_key": "NHC_0024_deposit_report_an_issue",
                      "timelineEventId": "be84efa7-5c02-46de-ae19-9cbb452f00e6",
                      "createdAt": "2023-11-12T13:10:40.554925Z",
                      "amount": "100.000000",
                      "currency": "EUR"
                    },
                    "contextCategory": "NHC"
                  }
                },
                "style": "highlighted",
                "type": "listItemAvatarDefault"
              },
              "style": "plain"
            }
          ],
          "action": null,
          "type": "table"
        }
      ]
    },
    "has_docs": true
  },

Environment

  • OS: MacOS
  • pytr version: 0.3.1
@AiroPi AiroPi added the bug Something isn't working label Dec 4, 2024
@Austinpwrs
Copy link

Austinpwrs commented Dec 7, 2024

Liegt wahrscheinlich daran, dass der eventType: "PAYMENT_INBOUND_APPLE_PAY" hier fehlt: event.py.

Füg da mal folgendes hinzu und versuch es nochmal:

tr_event_type_mapping = {
# Deposits
"INCOMING_TRANSFER": PPEventType.DEPOSIT,
"INCOMING_TRANSFER_DELEGATION": PPEventType.DEPOSIT,
"PAYMENT_INBOUND": PPEventType.DEPOSIT,
"PAYMENT_INBOUND_GOOGLE_PAY": PPEventType.DEPOSIT,
"PAYMENT_INBOUND_APPLE_PAY": PPEventType.DEPOSIT # das hier extra hinzufügen und alles andere lassen wies war
#... anderen eventTypes
"TRADE_INVOICE": ConditionalEventType.TRADE_INVOICE,
}

@AiroPi
Copy link
Author

AiroPi commented Dec 8, 2024

That was it. I will open a PR asap. Thanks!

@AiroPi AiroPi linked a pull request Dec 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants