[Refactor] Make @tensorclass work properly with pyright #1042
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes in detail.
Motivation and Context
pyright: error:
Types of changes
I looked at the
@dataclass
implementation and mimicked the behavior here. I'm no expert in typing.Potential breaking change:
Technically you could have used @tensordict the following:
@tensordict(<bool_for_autocast_without_using_the_keyword>)
or
@tensordict(<bool_for_autocast_without_using_the_keyword>, <bool_for_frozen_without_using_the_keyword>)
This will break now but I doubt any sane person uses it like that, cs.github.com did not show any such usage when I looked for it.
Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!