[ET-VK] Replace Uniform buffers with push constants for binary op #7230

trivedivivek · 2024-12-06T20:38:52Z

Stack from ghstack (oldest at bottom):

[ET-VK] Replace Uniform buffers with push constants for copy op #7267
[ET-VK] Replace Uniform buffers with push constants for permute op #7231
-> [ET-VK] Replace Uniform buffers with push constants for binary op #7230
[ET-VK] Replace Uniform buffers with push constants for view op #7229
[ET-VK] Adding convenience functions in Compute graph to get PushConstantDataInfo for various attributes of a tensor. #7224
[ET-VK] Add PushConstantDataInfo and vector to hold push constants data in DispatchNode. #7223

This diff replaces uniform buffers with push constants for binary op in the Vulkan backend of Executorch. The changes include updating the GLSL code to use push constants instead of uniform buffers and updating the C++ code to pass the sizes as push constants to the shader.

Differential Revision: D66853542

This diff replaces uniform buffers with push constants for binary op in the Vulkan backend of Executorch. The changes include updating the GLSL code to use push constants instead of uniform buffers and updating the C++ code to pass the sizes as push constants to the shader. Differential Revision: [D66853542](https://our.internmc.facebook.com/intern/diff/D66853542/) [ghstack-poisoned]

pytorch-bot · 2024-12-06T20:38:56Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7230

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 19 New Failures, 2 Unrelated Failures

As of commit 2ce975a with merge base e89e320 ():

NEW FAILURES - The following jobs have failed:

Build documentation / build (buck2) / Build doc (gh)
RuntimeError: Command docker exec -t 49cbfcccf809d2cf9feec54ce5e33eb38cbd3d3e11776a580fa7d8788be70617 /exec failed with exit code 2
Lint / lintrunner / linux-job (gh)
pull / test-eval_llama-mmlu-linux / linux-job (gh)
RuntimeError: Command docker exec -t ee9d66a63adfd79671015b4883cf0880c40718bb6c5e11811a102c3599e3dceb /exec failed with exit code 1
pull / test-eval_llama-wikitext-linux / linux-job (gh)
RuntimeError: Command docker exec -t b268d7c1e0bcfe7550376ea21668bae55cc86eed339de7628eb390ba8221590b /exec failed with exit code 1
pull / test-llama_runner_eager-linux / linux-job (gh)
RuntimeError: Command docker exec -t cb9cfd60f57d42343de02bb78b6a9582fb555dc33e17f3bda9b01f69b9572a1f /exec failed with exit code 1
pull / test-llama-runner-linux (bf16, custom) / linux-job (gh)
RuntimeError: Command docker exec -t 769af9ed2db0712a6d96c37696294826cfc256db0fe865936cc2e082db2c2122 /exec failed with exit code 1
pull / test-llama-runner-linux (bf16, portable) / linux-job (gh)
RuntimeError: Command docker exec -t cd36cde6e880e662aa81948fdc869488942acc88cd499029544fcc3b07865983 /exec failed with exit code 1
pull / test-llama-runner-linux (fp32, portable) / linux-job (gh)
RuntimeError: Command docker exec -t 98cd0174dcc06cc8fe46cba10084b96f82ae0be2301cf5a035cd45ab12dfe8bf /exec failed with exit code 1
pull / test-llama-runner-linux (fp32, xnnpack+custom) / linux-job (gh)
RuntimeError: Command docker exec -t 0873d01d4b244ca0f65329b0ab86cc8a71c2b519895d34bfb9521639dea1d31e /exec failed with exit code 1
pull / test-llama-runner-linux (fp32, xnnpack+custom+qe) / linux-job (gh)
RuntimeError: Command docker exec -t 0124a0f9fbe7eb9f89dbd4ebf10f484032cbdfe2b5caff759d82744784c99b83 /exec failed with exit code 1
pull / test-llama-runner-linux (fp32, xnnpack+custom+quantize_kv) / linux-job (gh)
RuntimeError: Command docker exec -t 9376ecde1403ed9039da8959d23538ea6b1f75318421644d65c831816a50b5fd /exec failed with exit code 1
pull / test-llama-runner-linux (fp32, xnnpack+quantize_kv) / linux-job (gh)
RuntimeError: Command docker exec -t 55efefd75434c6f1906b8789f35473335dd189bcc381ffb09f38b0d0cf2a74d0 /exec failed with exit code 1
pull / test-llama-runner-qnn-linux (fp32, qnn_16a16w, qnn) / linux-job (gh)
RuntimeError: Command docker exec -t c579ff950698b837ace3ff97df554a35af679b60b29bde91b40ae6e56b011f57 /exec failed with exit code 1
pull / test-llama-runner-qnn-linux (fp32, qnn_8a8w, qnn) / linux-job (gh)
RuntimeError: Command docker exec -t e34a8e319baa1ecec721b0e2434c2078e99c38ec98e1e72a04e78c84b15fa848 /exec failed with exit code 1
pull / test-models-linux (buck2, mv3, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh)
RuntimeError: Command docker exec -t 73da149f97a29111b4c297d4e8870f01156242b385a6db7a8d1038d2fdce5ff3 /exec failed with exit code 1
pull / test-models-linux (cmake, mv3, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh)
RuntimeError: Command docker exec -t 5f6464c34f25a00785ee1dc30a5b6ca879881211c19b2e018b1898be6fb19024 /exec failed with exit code 1
pull / test-models-linux (cmake, vit, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh)
RuntimeError: Command docker exec -t 2496bf345040b1bc123358bfe4ce0d7675428a664151c919ce9180eec4aee29b /exec failed with exit code 1
pull / unittest / linux / linux-job (gh)
RuntimeError: Command docker exec -t 9a2e3b6b10b795b99b29160ad6551672630d06522f21092d97a9055bd4eaf51f /exec failed with exit code 1
pull / unittest-arm / linux-job (gh)
RuntimeError: Command docker exec -t 95180a612f41d9a1feffa59a80c1ba2ae41d27ee884266357a3c592ae52a1c6a /exec failed with exit code 1

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / test-llava-runner-linux / linux-job (gh) (trunk failure)
test_llava
pull / unittest / macos / macos-job (gh) (trunk failure)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-12-06T20:39:19Z