[ET-VK] Add PushConstantDataInfo and vector to hold push constants data in DispatchNode. #7223

trivedivivek · 2024-12-06T16:53:17Z

Stack from ghstack (oldest at bottom):

[ET-VK] Replace Uniform buffers with push constants for copy op #7267
[ET-VK] Replace Uniform buffers with push constants for permute op #7231
[ET-VK] Replace Uniform buffers with push constants for binary op #7230
[ET-VK] Replace Uniform buffers with push constants for view op #7229
[ET-VK] Adding convenience functions in Compute graph to get PushConstantDataInfo for various attributes of a tensor. #7224
-> [ET-VK] Add PushConstantDataInfo and vector to hold push constants data in DispatchNode. #7223

This diff adds a new class called PushConstantDataInfo to the DispatchNode class in the Vulkan backend for Executorch.
This class represents a push constant data entry, which can either be a shared pointer to a tensor's uniform data with an attribute or data with a maximum size of 16 bytes.
The write method is also added to this class, which writes the data to a destination buffer.

Differential Revision: D66796049

…ta in DispatchNode. This diff adds a new class called `PushConstantDataInfo` to the `DispatchNode` class in the Vulkan backend for Executorch. This class represents a push constant data entry, which can either be a shared pointer to a tensor's uniform data with an attribute or data with a maximum size of 16 bytes. The `write` method is also added to this class, which writes the data to a destination buffer. Differential Revision: [D66796049](https://our.internmc.facebook.com/intern/diff/D66796049/) [ghstack-poisoned]

pytorch-bot · 2024-12-06T16:53:21Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7223

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 19 New Failures, 2 Unrelated Failures

As of commit bf21749 with merge base e89e320 ():

NEW FAILURES - The following jobs have failed:

Build documentation / build (buck2) / Build doc (gh)
RuntimeError: Command docker exec -t 760edfd54262ad07dfb82da907f352334f0fde3c00073d4fb466a40ee6775934 /exec failed with exit code 2
Lint / lintrunner / linux-job (gh)
>>> Lint for devtools/bundled_program/test/test_bundle_data.py:
pull / test-eval_llama-mmlu-linux / linux-job (gh)
RuntimeError: Command docker exec -t a8582db63add1cab220955b3b339e1ef1b98695ba0315d90f39c2e0c334e386a /exec failed with exit code 1
pull / test-eval_llama-wikitext-linux / linux-job (gh)
RuntimeError: Command docker exec -t 0c90eb2d8cdc4cee11d062dc8f3b0914c52ffa6008424370f36188821f2cfab1 /exec failed with exit code 1
pull / test-llama_runner_eager-linux / linux-job (gh)
RuntimeError: Command docker exec -t fd34c9f7954086cfa7e8e7882f304ed1d853020641a48a477c5f7c0201b299a1 /exec failed with exit code 1
pull / test-llama-runner-linux (bf16, custom) / linux-job (gh)
RuntimeError: Command docker exec -t 313edd95a3fffc42e39f02484bd528dbf07cdb73ce7a30e225747f572d456583 /exec failed with exit code 1
pull / test-llama-runner-linux (bf16, portable) / linux-job (gh)
RuntimeError: Command docker exec -t d5cabe8bb8e465fa275566c32b40ae24b6a9320498ed8d312765f47bf40ccc1f /exec failed with exit code 1
pull / test-llama-runner-linux (fp32, portable) / linux-job (gh)
RuntimeError: Command docker exec -t f0c831d95e47238988987e1d24bd1cdc22979a57fc912167509d3be3bff0a785 /exec failed with exit code 1
pull / test-llama-runner-linux (fp32, xnnpack+custom) / linux-job (gh)
RuntimeError: Command docker exec -t 1e1c0391057e80992713ca96d4f38dac9ebeaa4e121dd53ddaf75e2fdc8e7a48 /exec failed with exit code 1
pull / test-llama-runner-linux (fp32, xnnpack+custom+qe) / linux-job (gh)
RuntimeError: Command docker exec -t 8ed7f74d099220659e949393ba588a6ff6d66a4aee60281f9b60e078b189fecd /exec failed with exit code 1
pull / test-llama-runner-linux (fp32, xnnpack+custom+quantize_kv) / linux-job (gh)
RuntimeError: Command docker exec -t b5f1143e624c66c6e67cac2c54e2f45e5c03ae1d7ac083e82243ab75631f3a0d /exec failed with exit code 1
pull / test-llama-runner-linux (fp32, xnnpack+quantize_kv) / linux-job (gh)
RuntimeError: Command docker exec -t 44e0d792215bbb26116f191e994c63bc999fbf4a7c908e2e97be9506ec671345 /exec failed with exit code 1
pull / test-llama-runner-qnn-linux (fp32, qnn_16a16w, qnn) / linux-job (gh)
RuntimeError: Command docker exec -t a04315ceedcd2fdf0797a8781afa4c1f2e1f76d0157c04eeedc493ac75aa0835 /exec failed with exit code 1
pull / test-llama-runner-qnn-linux (fp32, qnn_8a8w, qnn) / linux-job (gh)
RuntimeError: Command docker exec -t a552e94029a7461396569a5e381a0c049bd68b6939db8c0913fd3d44e075254c /exec failed with exit code 1
pull / test-models-linux (buck2, mv3, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh)
RuntimeError: Command docker exec -t 3ca71cb6417d816d7dc26a2cce6dbc3d00c537691cd648af361c63172da2aea0 /exec failed with exit code 1
pull / test-models-linux (cmake, mv3, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh)
RuntimeError: Command docker exec -t 2ea0087a92c261a14be4f34d0300e6ab845c6d470fdfa9fdc984a3f9c4616683 /exec failed with exit code 1
pull / test-models-linux (cmake, vit, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh)
RuntimeError: Command docker exec -t 91b10ee20e4c2f6b21714af2fc80470ca548c269727aea6beaf23c586b78e96f /exec failed with exit code 1
pull / unittest / linux / linux-job (gh)
RuntimeError: Command docker exec -t 52c568695010a40b5b4659739d448f698ee2e364754ad2e651818fbdf4ae5323 /exec failed with exit code 1
pull / unittest-arm / linux-job (gh)
RuntimeError: Command docker exec -t 73cff341303bd56a89cf055c13c7c3198058872a493c5c9f674aa9a4d133e6f2 /exec failed with exit code 1

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / test-llava-runner-linux / linux-job (gh) (trunk failure)
test_llava
pull / unittest / macos / macos-job (gh) (trunk failure)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-12-06T16:53:40Z