[ET-VK] Adding function to set push constants in Command buffer. #7221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff adds a function to set push constants in the Command buffer for ET-VK. The changes include adding a new `set_push_constants` function to the CommandBuffer class and modifying the code in the CommandBuffer class to call this new function. Differential Revision: [D66714317](https://our.internmc.facebook.com/intern/diff/D66714317/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7221
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 638c78d with merge base b9db0a3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66714317 |
This was referenced Dec 6, 2024
trivedivivek
added
the
release notes: backends
SS-JIA
approved these changes
Dec 6, 2024
…uffer." This diff adds a function to set push constants in the Command buffer for ET-VK. The changes include adding a new `set_push_constants` function to the CommandBuffer class and modifying the code in the CommandBuffer class to call this new function. Differential Revision: [D66714317](https://our.internmc.facebook.com/intern/diff/D66714317/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66714317 |
…uffer." This diff adds a function to set push constants in the Command buffer for ET-VK. The changes include adding a new `set_push_constants` function to the CommandBuffer class and modifying the code in the CommandBuffer class to call this new function. Differential Revision: [D66714317](https://our.internmc.facebook.com/intern/diff/D66714317/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66714317 |
…uffer." This diff adds a function to set push constants in the Command buffer for ET-VK. The changes include adding a new `set_push_constants` function to the CommandBuffer class and modifying the code in the CommandBuffer class to call this new function. Differential Revision: [D66714317](https://our.internmc.facebook.com/intern/diff/D66714317/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66714317 |
facebook-github-bot
merged commit b6df23b
into
gh/trivedivivek/20/base
44 of 45 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Dec 10, 2024
Pull Request resolved: #7221 This diff adds a function to set push constants in the Command buffer for ET-VK. The changes include adding a new `set_push_constants` function to the CommandBuffer class and modifying the code in the CommandBuffer class to call this new function. ghstack-source-id: 257227241 @exported-using-ghexport Differential Revision: [D66714317](https://our.internmc.facebook.com/intern/diff/D66714317/)
kirklandsign
pushed a commit
that referenced
this pull request
Dec 10, 2024
Pull Request resolved: #7221 This diff adds a function to set push constants in the Command buffer for ET-VK. The changes include adding a new `set_push_constants` function to the CommandBuffer class and modifying the code in the CommandBuffer class to call this new function. ghstack-source-id: 257227241 @exported-using-ghexport Differential Revision: [D66714317](https://our.internmc.facebook.com/intern/diff/D66714317/) Co-authored-by: Vivek Trivedi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff adds a function to set push constants in the Command buffer for ET-VK. The changes include adding a new
set_push_constantsfunction to the CommandBuffer class and modifying the code in the CommandBuffer class to call this new function.Differential Revision: D66714317